[desktop] Fix making excessive handshakes #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
fix-desktop-handshakes-6053
branch
from
f5dfb4e
to
e59d589
Compare
charlag
force-pushed
the
fix-desktop-handshakes-6053
branch
from
e59d589
to
39a330f
Compare
ganthern
approved these changes
Nov 13, 2023
ganthern
force-pushed
the
fix-desktop-handshakes-6053
branch
2 times, most recently
from
a5adb2e
to
4e4f66a
Compare
Since we switched to built-in fetch() as our implementation we noticed that a number of users are making excessive TLS handshakes. We've found that by default undici (that's powering node's built-in fetch()) has low idle timeout and has no default limit for connections. We are now explicitly using undici (also more recent version) with explicitly configured dispatcher to adjust the http client parameters. We should switch to HTTP2 once it stabilizes in undici. fix #6053
ganthern
force-pushed
the
fix-desktop-handshakes-6053
branch
from
4e4f66a
to
237febb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6053
see tutadb!527