Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] Update the .desktop entry to reflect recent Tutanota name change #6573

Merged
merged 2 commits into from Feb 26, 2024

Conversation

iakmds
Copy link
Contributor

@iakmds iakmds commented Feb 18, 2024

Background:

Currently, the desktop entry for linux shows a) Tutanota Desktop as the application title and b) The desktop client for Tutanota, the secure e-mail service. as the description.

Changes:

This PR changes all strings from "Tutanota" to "Tuta" inside the DesktopIntegratorLinux.ts to reflect the recent name change from Tutanota to Tuta. Perhaps it should be "Tuta Mail" instead of just "Tuta"? Let me know what you think.

Test ntoes

  • Check that linux app shows up as "Tuta Mail"

@charlag
Copy link
Contributor

charlag commented Feb 19, 2024

hi, thanks for the change!

Yes, it should say Tuta Mail, I'm surprised it's not pulled out of some other metadata to be honest.

I don't think we should change that X-Tutanota header though

@iakmds
Copy link
Contributor Author

iakmds commented Feb 19, 2024

Thank you for your comment. I changed the header back to X-Tutanota and replaced Tuta with Tuta Mail.

Copy link
Contributor

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you so much!
I think we could also drop "Desktop" part now that I look at it.

@iakmds
Copy link
Contributor Author

iakmds commented Feb 20, 2024

Should be good now :)

@charlag
Copy link
Contributor

charlag commented Feb 20, 2024

Ah thank you!

@charlag
Copy link
Contributor

charlag commented Feb 26, 2024

Sorry we were tweaking CI to be able to build the PRs from forks!

@charlag charlag added this pull request to the merge queue Feb 26, 2024
Merged via the queue into tutao:master with commit 1eb3413 Feb 26, 2024
1 check passed
@wrdhub wrdhub self-assigned this Feb 27, 2024
@wrdhub wrdhub added state:done meets our definition of done state:tested We tested it and are about to release it labels Feb 27, 2024
@wrdhub wrdhub removed their assignment Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants