Sidebar menu opened by tab + enter does not receive focus #7123
Conversation
andrehgdias
force-pushed
the
7118-sidebar-menu-opened-by-tabenter-does-not-receive-focus
branch
2 times, most recently
from
8e159c9
to
36040ee
Compare
- exporting hadleFocus() from GuiUtils Co-authored-by: rih <rih@tutao.de>
andrehgdias
force-pushed
the
7118-sidebar-menu-opened-by-tabenter-does-not-receive-focus
branch
from
36040ee
to
c80504f
Compare
| @@ -363,6 +365,9 @@ export class ViewSlider implements Component<ViewSliderAttrs> { | |||
| }) | |||
| .finally(() => { | |||
| foregroundColumn.isInForeground = toForeground | |||
| if (foregroundColumn.domColumn && !toForeground) { | |||
There was a problem hiding this comment.
the previous attempt by @jalhubb was similar and led to some issues, I think would be good if he could check it
| show() { | ||
| this.focusedBeforeShown = document.activeElement as HTMLElement | ||
| this.turnTrapFocus(true) | ||
| handleFocus(true, [".main-view"]) |
There was a problem hiding this comment.
It might be nicer to curry this rather than pass in [".main-view"] each time.
| onupdate(vnode: m.VnodeDOM<Attrs>): any { | ||
| if (vnode.dom.parentElement) { | ||
| const trapFocus = vnode.dom.parentElement.style.visibility === "visible" | ||
| handleFocus(trapFocus, ["nav", ".view-columns"]) | ||
| } | ||
| }, |
There was a problem hiding this comment.
This couples the FolderColumnView to the ViewSlider which will be not so nice when we refactor the ViewSlider. I would also advise against giving components access to their parents if possible.
Have you tried creating an isFocused attribute then passing in (vnode.dom as HTMLElement).style.visibility === "visible" from the ViewSlider into it?
|
Opening the sidebar then resizing the window to three column layout, then back to single column view causes the sidebar to become unopenable. |
Co-authored-by: rih rih@tutao.de
Closes #7118