Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sveltekit fetch #414

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: sveltekit fetch #414

merged 1 commit into from
Aug 18, 2023

Conversation

jouwdan
Copy link
Member

@jouwdan jouwdan commented Aug 18, 2023

Please check if the PR fulfills these requirements

  • The commit message is sensible and easily understood
  • Tests for the changes have been added (for bug fixes / features where relevant)
  • Docs have been added / updated (for bug fixes / features where relevant)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes the console error when loading courses:

Loading ${COURSE_URL} using window.fetch. For best results, use the fetch that is passed to your load function: https://kit.svelte.dev/docs/load#making-fetch-requests

What commits does this PR relate to?

Thank you for your contribution

We hope you stay around and connect with our growing community!

@jouwdan jouwdan linked an issue Aug 18, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for tutors-alpha failed.

Name Link
🔨 Latest commit bec2089
🔍 Latest deploy log https://app.netlify.com/sites/tutors-alpha/deploys/64df4eb650a2fb00084e9e58

@jouwdan jouwdan merged commit c7d82f5 into development Aug 18, 2023
2 of 7 checks passed
@ghost
Copy link

ghost commented Aug 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jouwdan jouwdan deleted the fix/sveltekit-fetch branch August 18, 2023 13:49
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App: Pass sveltekit fetch from load function to course service
1 participant