Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/toc companions walls cypress test#393 #455

Conversation

20041540MichaelKelly
Copy link
Contributor

Please check if the PR fulfills these requirements

  • [x ] The commit message is sensible and easily understood
  • [ x] Tests for the changes have been added (for bug fixes / features where relevant)
  • Docs have been added / updated (for bug fixes / features where relevant)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a feat, a refactor of the cypress tests

Cypress Testing:
Static html Generator:
cd /doc/reference-course
npx tutors-publish-html <= This will generate a html folder
This html folder is our static html Generator that we will be testing locally
Inside the project directory of doc/reference-course
run this cmd => npx cypress open
This will open the Cypress Testing UI
Important! comment back in line 27 if you want the test to run as it should.
This line was commented out because the video link was missing.

Dynamic Reader:
	cd /app
		run this cmd => npx cypress open
		This will open the Cypress Testing UI

What commits does this PR relate to?

pr: feat/toc-companions-walls-cypress-test#393

Thank you for your contribution

We hope you stay around and connect with our growing community!

…tion of reference-manual and reference-course to a new directory called doc. Also Cypress is after being moved into the tutors-publish-html to perform static local testing
…the /app directory and refactored out the static html generator into its new directory of doc/reference-course. directions to run the tests: Cypress Testing:

    Static html Generator:
        cd /doc/reference-course
            npx tutors-publish-html <= This will generate a html folder
            This html folder is our static html Generator that we will be testing locally
        Inside the project directory of doc/reference-course
            run this cmd => npx cypress open
            This will open the Cypress Testing UI
    Important! comment back in line 27 if you want the test to run as it should.
               This line was commented out because the video link was missing.

    Dynamic Reader:
        cd /app
            run this cmd => npx cypress open
            This will open the Cypress Testing UI
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for tutors-dev canceled.

Name Link
🔨 Latest commit dc153fa
🔍 Latest deploy log https://app.netlify.com/sites/tutors-dev/deploys/64ea2d17eca48e0008951b22

@ghost
Copy link

ghost commented Aug 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jouwdan jouwdan merged commit 34ab7d7 into tutors-sdk:development Aug 26, 2023
7 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants