Fix tutors links overflowing on mobile #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2024 15:00
…t two buttons to keep alternating colour scheme.
…m component, Links.svelte.
✅ Deploy Preview for redirect-tutors-reader canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix. Fixes #639. The links in both TutorsLinks.svelte and Welcome.svelte were overflowing on mobile. To fix I added a media query via tailwind of 2 columns only above small screen size. In order to keep the colour scheme I ordered the divs appropriately,and reordered them above the small size. I then created a new custom component to eliminate reused code in both files called Links.svelte, placed in the src/lib/ui/navigators. This may not be the best place or name for this component, although it is what I judged best based on my limited knowledge of the codebase.
Finally, I was unable to confirm that my code works on the dashboard page, as I was unable to navigate there on the build running on my machine due to github auth not working. I am fairly certain that it should work perfectly.
What commits does this PR relate to?
Thank you for your contribution
We hope you stay around and connect with our growing community!
I am in first year in the Hdip at SETU and this is my first ever PR. While I have done my best to follow any established protocol, I am open to any feedback regarding my approach. Thank you.