This repository has been archived by the owner on May 4, 2021. It is now read-only.
v0.14.0 #3
Merged
v0.14.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,7 +97,33 @@ do | |||
| echo "No images need to be cleaned" | |||
| fi | |||
|
|
|||
| rm -f ToBeCleanedImageIdList ContainerImageIdList ToBeCleaned ImageIdList KeepImageIdList | |||
| # Remove unused volumes | |||
| echo "=> Start to clean unused volums" | |||
There was a problem hiding this comment.
Could we clean volumes only if they are unused for, lets say, more than 24h?
When the user is redeploying a container, its volumes are "unused" from the time the previous container is destroyed until the time the new container is destroyed. Also, if the new container deployment fails, the volumes would be reused if the user retries a redeploy operation after a while. I think 24h is a good compromise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.