Clear the framebuffer in mipi_display_init() #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initializes the display controller's internal frame buffer to all black before turning the display itself on, to avoid initially displaying random pixels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializes the display controller's internal frame buffer to all black before turning the display itself on, to avoid initially displaying random pixels.
I'm not sure that the way I fixed it in this PR is the best way, I'm open to feedback and suggestions.
To demonstrate what I mean, here are two slow-mo videos of the
pico_effectsfirmware. The first one shows the current behavior (hagl_pico_mipi master branch, commit a3abacd), note that the display shows two different "noise" screens at startup, before the demo starts:without-clear.mp4
The first noise screen is due to hagl_hal not clearing the display's frame buffer before turning the display on. This PR fixes that. The second noise screen is is from
pico_effectsitself, i'm not going to worry about that ;-)with-clear.mp4