Update php-jwt to 5.0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the tests pass but the HHVM test does not pass because "HHVM is no longer supported on Ubuntu Precise. Please consider using Trusty with |
|
You mean it does not have a BC break? I was looking for a reason why they pumped up the main version number. It usually means there is a BC break, but maybe they are just not following semantic versioning. |
|
Merged, thanks! |
|
@tuupola Yes I think that they don't follow the semantic versioning. |
|
Released as 2.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
php-jwt does not have BC and all the tests pass, I just updated the composer for the version 5.