Added tuva prefix to schema name #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only schema that is missing the tuva prefix. I reused the code from other models to add it.
|
Workflow has finished with the following statuses:
|
|
Hello @galletsophie - Thank you for submitting this PR! Your changes makes total sense so it's been approved and now I just need to run it through our CI/CD process. I'll update you when this is complete. Thanks! |
|
Workflow has finished with the following statuses:
|
|
@galletsophie - I've merged your PR. The changes will be public once we release a new version of the The Tuva Project which we account via Slack. |
tuvaforrest
pushed a commit
that referenced
this pull request
May 7, 2024
This is the only schema that is missing the tuva prefix. I reused the code from other models to add it. Co-authored-by: thutuva <101137626+thutuva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Claims Expanded is the only schema that is missing the tuva prefix when I run it.
I reused the code from other models.yml to add it.
How has this been tested?
I tested it by running it locally. I set the tuva_schema_prefix variable in the main dbt_project.yml.
It correctly prefixed it to the schema name in the output warehouse, in Snowflake.
Reviewer focus
Please summarize the specific items you’d like the reviewer(s) to look into.
Checklist before requesting a review
(Optional) Gif of how this PR makes you feel
Loom link