Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outside contributor workflow to use value from user input #483

Merged
merged 2 commits into from
May 24, 2024

Conversation

sarah-tuva
Copy link
Member

Describe your changes

  • Updated the step "actions/checkout@v2" for each job in the outside contributor workflow to use the prNumber input to check out the PR branch. This should avoid the need to enter the PR and have to select the correct branch when running the workflow.
  • Renamed the job "dbt_v1.6.3_snowflake_build_full_clinical.yml" to "dbt_v1.6.3_snowflake_build_full_refresh.yml" to match the pattern of the other jobs. This job runs both claims and clinical, not just clinical.

How has this been tested?

Used GitHub Act to test the workflow locally and confirmed the PR input was being used to check out the PR branch rather than checking out main by default.

Screenshot 2024-05-23 at 4 42 11 PM

Screenshot 2024-05-23 at 4 43 38 PM

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@sarah-tuva sarah-tuva added the bug Something isn't working label May 23, 2024
@tuvaforrest tuvaforrest merged commit 538605c into main May 24, 2024
5 checks passed
@tuvaforrest tuvaforrest deleted the fix-outside-contributor-workflow branch May 24, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants