Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena Compatibility #503

Merged
merged 13 commits into from
Jun 20, 2024
Merged

Athena Compatibility #503

merged 13 commits into from
Jun 20, 2024

Conversation

bradmontierth
Copy link
Contributor

@bradmontierth bradmontierth commented Jun 17, 2024

Describe your changes

  • explicitly cast all columns to the same data type that are being concatenated together if they are different data types
    • example: (claim_id||'-'||cast(claim_line_number as {{ dbt.type_string() }}
  • left() and right() replaced with substring()
  • removed USING clause in join
  • renamed normalized to normalized_cte
  • removed qualify statement and added cte
  • replaced floats with {{ dbt.type_float() }}
  • replaced numeric with {{ dbt.type_numeric() }})
  • using datediff instead of subtracting dates
  • using double quotes to for quote inside of string
  • removed insights mart as it had a lot of issues above and we will be replacing with data quality mart

How has this been tested?

successfully ran in athena enviro

Reviewer focus

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Terrible

Loom link

@bradmontierth bradmontierth changed the title testing substring Athena Compatibility Jun 19, 2024
thutuva
thutuva previously approved these changes Jun 20, 2024
Copy link
Member

@thutuva thutuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thutuva thutuva merged commit 41a1b10 into main Jun 20, 2024
5 checks passed
@thutuva thutuva deleted the athena_compatibility branch June 20, 2024 19:43
@thutuva thutuva restored the athena_compatibility branch June 24, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants