Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code and description columns #508

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

thutuva
Copy link
Member

@thutuva thutuva commented Jun 21, 2024

Describe your changes

Please include a summary of any changes.
This PR performs two major changes:

  1. Adding description columns next to code column (e.g. adding ndc_description next to ndc_code)
  2. Changing NPI columns to ID to clarify JOIN (e.g. billing_npi > billing_id; JOIN on practitioner_id) and adding facility or practitioner names

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.

  • local dbt build runs successfully
  • CI testing

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.
Confirm all column have been changed from NPI to ID and descriptions are added where needed

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

https://www.loom.com/share/7b8a5e35d9074c80a3f8ba64752381d0?sid=45acd976-572b-4f3c-ba4b-152397c1de8f

…tor_code_and_description

# Conflicts:
#	models/claims_preprocessing/normalized_input/final/normalized_input__pharmacy_claim.sql
@thutuva thutuva added breaking-change Changes have been made that may cause other components to fail enhancement labels Jun 21, 2024
@thutuva thutuva changed the title Refactor code and description column Refactor code and description columns Jun 21, 2024
@bradmontierth bradmontierth merged commit 1557c85 into main Jun 21, 2024
5 checks passed
@bradmontierth bradmontierth deleted the refactor_code_and_description branch June 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes have been made that may cause other components to fail enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants