Use libxml2 to get info from svg files for frame counts since librsvg doesn't let you access the description anymore. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't let you access the description anymore.
|
Oh -- and I also included a change necessary to get builds to work. |
wjt
added a commit
to wjt/com.tux4kids.tuxmath
that referenced
this pull request
Nov 20, 2019
Includes a backport of tux4kids/t4kcommon#5 to deal with rsvg_handle_get_desc() always returning NULL in modern librsvg.
wjt
added a commit
to wjt/com.tux4kids.tuxtype
that referenced
this pull request
Nov 21, 2019
Includes a backport of tux4kids/t4kcommon#5 to deal with rsvg_handle_get_desc() always returning NULL in modern librsvg.
|
thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Librsvg doesn't give access to the internal xml structure of an SVG any more, and since frame counts are embedded in the attribute of the svg's in tuxmath, we need to switch to libxml2 to get framecounts when loading svg sprites.