Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dutch translation #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

martijndeb
Copy link

Basically adds everything for a Dutch locale. Tested by setting the langId by hand.

Adds localeNl and localeNlExtra variables and registeres them.
Adds Dutch xliff translation.

Copy link
Member

@vinzv vinzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the translation!
One string is still missing. Could you please add it?

src/ng-app/assets/locale/lang.nl.xlf Outdated Show resolved Hide resolved
Translate missing string
@vinzv vinzv requested a review from tuxedoxt April 21, 2020 14:30
@vinzv vinzv added the enhancement New feature or request label Apr 21, 2020
@vinzv vinzv self-requested a review April 21, 2020 20:57
@tuxedoherbert
Copy link

Thanks again for the translation. We could add this and other languages now, so please be so kind and update the files suitable for TCC 1.1.0 :)

@martijndeb
Copy link
Author

@tuxedoherbert I've pulled in from master, and opened both files in a diff tool. Too much to merge manually, what do you guys use to update the XLF files? I could merge manually by copying values into a new copy of the english or german version, but I bet it's possible to update the file, just as PO files can?

Update using pomerge from lang.xlf, and improve the missing translations
@martijndeb
Copy link
Author

@tuxedoherbert I've merged using pomerge, and updated the translations to the master branch accordingly.
This should then now be ready to merge if approved.

@ghost
Copy link

ghost commented Mar 27, 2022

Update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants