Adding support for Smart Star Projector device class (xktyd) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed base branch to dev |
|
Are you working on this one? Would be great to have support for it, now the light entity is quite limited, and not possible to use all functions like laser/motor... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This device class is not documented officially by the manufacturer, who has taken some liberties in using official DPCodes and creating custom ones.
The device consists of a nebula light, a laser projector, and a motor that rotates them. It offers three work modes: manual, scene, and music. However, I have only been able to implement the manual mode as I could not locate the payload documentation for the other two modes.
The motor control is exposed using fan DPCodes, it would be nice to refactor the fan entity implementation to support HA FanEntityDescription, so we could correctly set the entity name and use custom icons.