Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msp category for cat toilets #92

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

cperrin88
Copy link

Description

Added new device category msp for cat toilets.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I did limited local testing with a cat toilet (KatzenRobo). Unfortunately they only support only a few of the standard instructions but these work well.

  • Local Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cperrin88
Copy link
Author

I need help with the supported_devices_cn.md. I don't speak chinese.

@shihuimiao
Copy link
Collaborator

can you offer the Device diagnostic file, so i can test it.

@cperrin88
Copy link
Author

Sure. Here it is:

smartlife-diagnostics.json

@cperrin88
Copy link
Author

Do you need anything to merg this or is this dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants