Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal7's paneMargin should be in pixels in css #2

Closed
daonb opened this issue May 25, 2020 · 0 comments
Closed

terminal7's paneMargin should be in pixels in css #2

daonb opened this issue May 25, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@daonb
Copy link
Contributor

daonb commented May 25, 2020 •
edited

Completely remove the Terminal7.paneMargin and use css margin to set it.
@daonb daonb added bug Something isn't working good first issue Good for newcomers labels May 25, 2020
@daonb daonb changed the title terminal7's paneMargin should be in pixels terminal7's paneMargin should be in pixels in css May 27, 2020
daonb added a commit that referenced this issue May 30, 2020
@daonb
Removing last refs to paneMargin and closing #2
e381631
@daonb daonb closed this as completed May 31, 2020
@daonb daonb reopened this May 31, 2020
@daonb daonb closed this as completed May 31, 2020
daonb pushed a commit to daonb/terminal7 that referenced this issue Aug 17, 2022
@eyal-sasson
Merge pull request tuzig#2 from tuzig/adding_map
f6bdbb1 
Fixing the map & the connect form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daonb