Remove the prompt printed in the middle of subscribe cmd

[daonb]

Need to refactor the command to return a Promise and to call resolve() when truly finished.

[eyal-sasson]

what prompt? its really hard to test it on the web

[daonb]

Look at the code of the subscribe command function and you can see it returns before the operation is completed. We've talked about it briefly last week - we need to return a Prmosie and call resolve only when the command is done.

[eyal-sasson]

are we talking about shell.onPurchasesUpdate(data)? its the line commented out.
i will refactor it to be asynchronous. what do we pass as data?

[daonb]

We're talking about the sub command itself. Getting that event is part of the command flow, so we should reject /resolve until we got the event, asked the user for his email, print the QR code and validate it. בתאריך יום ה׳, 1 ביוני 2023, 10:10, מאת Eyal Sasson ‏< ***@***.***>:

…

are we talking about shell.onPurchasesUpdate(data)? its the line commented out. i will refactor it to be asynchronous. what do we pass as data? — Reply to this email directly, view it on GitHub <#371 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI75GNPI5W3NXRVNE6ZZTXJA57PANCNFSM6AAAAAAYTFTASY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[daonb]