Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixing #285

Closed
wants to merge 7 commits into from
Closed

Bug fixing #285

wants to merge 7 commits into from

Conversation

eyal-sasson
Copy link
Contributor

@eyal-sasson eyal-sasson commented Sep 13, 2022

Resolves #281, resolves #284.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for terminal7 ready!

Name Link
🔨 Latest commit 6c4aa6c
🔍 Latest deploy log https://app.netlify.com/sites/terminal7/deploys/63346763c983cf000828349c
😎 Deploy Preview https://deploy-preview-285--terminal7.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daonb
Copy link
Contributor

daonb commented Sep 14, 2022

Why did you remove the "under construction" message?
Was it causing a bug or did you just found it annoying?

I added it because typing an getting nothing seems like a bug.
One we have #135 this message will go away.

@eyal-sasson
Copy link
Contributor Author

Why did you remove the "under construction" message? Was it causing a bug or did you just found it annoying?

I added it because typing an getting nothing seems like a bug. One we have #135 this message will go away.

Honestly I thought it was bugged but it still seems weird to me that full lines are just printed in the middle of the welcome message

@eyal-sasson
Copy link
Contributor Author

The navigation flow is now refactored.

@eyal-sasson eyal-sasson changed the title Fixing small bugs Bug fixing Sep 20, 2022
@eyal-sasson
Copy link
Contributor Author

Pushed a change to the reconnection form to allow reconnecting even if the session was closed. Please let me know if it fixes #117.

src/cell.js Outdated Show resolved Hide resolved
@daonb daonb closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a form is going opening a new one closes it t0 have too many columns
2 participants