Refactored to allow multiple encodings, set two default encodings, maintained compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2015 17:24
As part of this, added two built-in encodings and a factory function: * DefaultEncoding is the encoding previously used by this library and has two methods renamed globally for compatibility reasons. * StdEncoding is the encoding used by Python's base58 package and, IIRC, bitcoin and others. The encoder structs have two new methods that accept byte-strings and emit byte-strings, also. Tests pass but none have been added to test new functionality, yet.
|
Sorry for almost literally never getting back to this, I just got around to bringing this code up to newer standards. I think I prefer simplicity over compatibility and potential for confusion. You may prefer using e.g. https://pkg.go.dev/github.com/cmars/basen and that's fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing but it might still be explosive to downstream users, I don't know. I needed to use a different alphabet, and instead of forking or creating a redundant new library, I decided having one canonical base58 made more sense.
Eager for your thoughts! :)