Fix compile on Mac OS 10.14 with Python 3.6. See pandas-dev/pandas#23424

tvajtay · Jun 11, 2019 · 7d825dc · 7d825dc
1 parent 1c7f415
commit 7d825dc
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -46,15 +46,18 @@
 # compile with:     python setup.py build_ext -i
 # clean up with:    python setup.py clean --all
 if sys.platform == 'darwin':
-	extra_compiler_args = ['-stdlib=libc++']
+        # see https://github.com/pandas-dev/pandas/issues/23424
+	extra_compiler_args = ['-stdlib=libc++']  # not needed #, '-mmacosx-version-min=10.9']
 else:
 	extra_compiler_args = []
 
 ext_modules = [Extension("caiman.source_extraction.cnmf.oasis",
                          sources=["caiman/source_extraction/cnmf/oasis.pyx"],
                          include_dirs=[np.get_include()],
                          language="c++",
-                         extra_compile_args = extra_compiler_args)]
+                         extra_compile_args = extra_compiler_args,
+                         extra_link_args = extra_compiler_args,
+                         )]
 
 setup(
     name='caiman',