Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prepared statements with positional arguments #22

Conversation

tvandinther
Copy link
Owner

@tvandinther tvandinther commented Feb 19, 2024

Closes #15

@tvandinther tvandinther added the enhancement New feature or request label Feb 19, 2024
@tvandinther tvandinther added this to the Version 1.0 milestone Feb 19, 2024
@tvandinther tvandinther self-assigned this Feb 19, 2024
@tvandinther tvandinther linked an issue Feb 19, 2024 that may be closed by this pull request
@tvandinther
Copy link
Owner Author

Prepared statement implementation on the C bindings are "non-connection". The binding build script needs to be updated to include this commit which adds the DB connection as a dependency for proper preparation.

This is in-scope for this PR and will be done next.

@tvandinther
Copy link
Owner Author

@tvandinther tvandinther force-pushed the 15-add-support-for-prepared-statements-with-positional-arguments branch from 39aadf3 to e68f8fa Compare July 7, 2024 13:20
If there are no returned rows, we can not parse it to find the column types. This check fixes a bug where the process would crash if there were no rows as it was using a null pointer to ask for column types.
@tvandinther tvandinther marked this pull request as ready for review July 7, 2024 14:59
@tvandinther tvandinther merged commit 9dc7366 into master Jul 7, 2024
6 checks passed
@tvandinther tvandinther deleted the 15-add-support-for-prepared-statements-with-positional-arguments branch July 7, 2024 15:02
tvandinther added a commit that referenced this pull request Jul 7, 2024
* Add positional argument tests

* Implement passing implementation of positional arguments for #15

* Change order of methods

* Refactor prepared statement into new class

* WIP

* remove prints

* add items to gitignore

* Add null check to row column type population

If there are no returned rows, we can not parse it to find the column types. This check fixes a bug where the process would crash if there were no rows as it was using a null pointer to ask for column types.

* make os for build runners consistent with test runners

* Add documentation for positional arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for prepared statements with positional arguments
1 participant