You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Playing the second game ( the one after the tutorial) I noticed that if I made 400 points I got the Admiral rank.
Steps to reproduce:
Start the Scouts First! mission
Play and make a score smaller than 500.
Check the rank at the end
Expected result:
You get the rank "Deserter"
Actual result:
You get the rank "Admiral"
Notes: I wasn't sure if it's ok to fork it and correct the bug myself , so I will tell you where you need to make the change.
There are two places where this appears so I assume that this also happens on both game modes.
In the src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeMarathon.java
and src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeSprint.java
In GameModeSprint.java Code line 47 says : 'return GameModeFactory.GAME_RANK_ADMIRAL;' and needs to be replaced with return GameModeFactory.GAME_RANK_DESERTER;
Same change in GameModeMarathon.java on line 45 .
Easy fix, I know.
The text was updated successfully, but these errors were encountered:
When Playing the second game ( the one after the tutorial) I noticed that if I made 400 points I got the Admiral rank.
Steps to reproduce:
Expected result:
You get the rank "Deserter"
Actual result:
You get the rank "Admiral"
Notes: I wasn't sure if it's ok to fork it and correct the bug myself , so I will tell you where you need to make the change.
There are two places where this appears so I assume that this also happens on both game modes.
In the src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeMarathon.java
and src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeSprint.java
In GameModeSprint.java Code line 47 says : 'return GameModeFactory.GAME_RANK_ADMIRAL;' and needs to be replaced with return GameModeFactory.GAME_RANK_DESERTER;
Same change in GameModeMarathon.java on line 45 .
Easy fix, I know.
The text was updated successfully, but these errors were encountered: