Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank 'Admiral' is displayed instead of 'Deserter' #5

Closed
trestianp opened this issue Nov 4, 2013 · 3 comments
Closed

Rank 'Admiral' is displayed instead of 'Deserter' #5

trestianp opened this issue Nov 4, 2013 · 3 comments

Comments

@trestianp
Copy link

When Playing the second game ( the one after the tutorial) I noticed that if I made 400 points I got the Admiral rank.

Steps to reproduce:

  1. Start the Scouts First! mission
  2. Play and make a score smaller than 500.
  3. Check the rank at the end

Expected result:
You get the rank "Deserter"

Actual result:
You get the rank "Admiral"

Notes: I wasn't sure if it's ok to fork it and correct the bug myself , so I will tell you where you need to make the change.
There are two places where this appears so I assume that this also happens on both game modes.
In the src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeMarathon.java
and src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeSprint.java
In GameModeSprint.java Code line 47 says : 'return GameModeFactory.GAME_RANK_ADMIRAL;' and needs to be replaced with return GameModeFactory.GAME_RANK_DESERTER;
Same change in GameModeMarathon.java on line 45 .
Easy fix, I know.

@vbarthel-fr
Copy link
Member

Thanks a lot :) if you want to request a pull, I'll be more than happy to
merge it and give you the credit :)

But if you don't have the time, I can fix it myself. It's up to you !

@trestianp
Copy link
Author

No, it's fine. You can fix it.
I will play a little more with this app and let you know if I see any issues.
I really like the idea and what you did .

@vbarthel-fr
Copy link
Member

b0d62f9 Thanks to you, it's fixed =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants