Clean row look

tvbarthel · Apr 22, 2014 · f2dc7d1 · f2dc7d1
1 parent 878930c
commit f2dc7d1
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 34 deletions.
diff --git a/app/src/main/java/fr/tvbarthel/apps/devredpe2014/MainActivity.java b/app/src/main/java/fr/tvbarthel/apps/devredpe2014/MainActivity.java
@@ -101,33 +101,26 @@ public boolean onOptionsItemSelected(MenuItem item) {
 
     private class MySimpleArrayAdapter extends ArrayAdapter<Look> {
 
-        class ViewHolder {
-            ImageView imageView;
-        }
 
         public MySimpleArrayAdapter(Context context, Look[] looks) {
             super(context, R.layout.row_look, looks);
         }
 
         @Override
         public View getView(final int position, View convertView, ViewGroup parent) {
-            if (convertView == null) {
-                LayoutInflater inflater = (LayoutInflater) getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
-                convertView = inflater.inflate(R.layout.row_look, parent, false);
-                ImageView imageView = ((ImageView) convertView.findViewById(R.id.row_look_rounded_image));
+            ImageView imageView = (ImageView) convertView;
 
-                ViewHolder viewHolder = new ViewHolder();
-                viewHolder.imageView = imageView;
-                convertView.setTag(viewHolder);
+            if (imageView == null) {
+                LayoutInflater inflater = (LayoutInflater) getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
+                imageView = (ImageView) inflater.inflate(R.layout.row_look, parent, false);
             }
 
-            final ViewHolder viewHolder = (ViewHolder) convertView.getTag();
             Picasso.with(MainActivity.this)
                     .load(getItem(position).getPreviewResourceId())
                     .placeholder(R.drawable.look_placeholder)
-                    .into(viewHolder.imageView);
+                    .into(imageView);
 
-            return convertView;
+            return imageView;
         }
 
     }

diff --git a/app/src/main/res/layout/activity_look_detail.xml b/app/src/main/res/layout/activity_look_detail.xml
@@ -16,8 +16,8 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:clipToPadding="false"
-        android:dividerHeight="1dp"
         android:divider="@color/white_translucent"
+        android:dividerHeight="1dp"
         android:listSelector="@android:color/transparent"
         android:scrollbars="none" />
 

diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
@@ -15,5 +15,6 @@
     android:scrollbars="none"
     android:paddingTop="?android:attr/actionBarSize"
     android:clipToPadding="false"
-    android:listSelector="@android:color/transparent"
+    android:listSelector="@drawable/look_selector"
+    android:drawSelectorOnTop="true"
     tools:context="fr.tvbarthel.apps.devredpe2014.MainActivity" />
diff --git a/app/src/main/res/layout/row_look.xml b/app/src/main/res/layout/row_look.xml
@@ -1,23 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<ImageView
+    xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
-    android:orientation="vertical"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:id="@+id/row_look_rounded_image"
+    android:layout_width="150dp"
+    android:layout_height="150dp"
+    android:layout_gravity="center"
+    android:scaleType="centerCrop"
+    tools:src="@drawable/r_look_1" />
 
-    <ImageView
-        android:id="@+id/row_look_rounded_image"
-        android:layout_width="150dp"
-        android:layout_height="150dp"
-        tools:src="@drawable/r_look_1"
-        android:scaleType="centerCrop"
-        android:layout_gravity="center" />
-
-    <View
-        android:layout_width="150dp"
-        android:layout_height="150dp"
-        android:background="@drawable/look_selector"
-        android:layout_gravity="center"/>
-
-</FrameLayout>