Fix a crash if the isPassedByReference want to check the parent of a …

…parent that does not exist. phpmd#1016
tvbeek · Feb 9, 2024 · 6a3af51 · 6a3af51
1 parent ea80ce8
commit 6a3af51
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/main/php/PHPMD/Rule/AbstractLocalVariable.php b/src/main/php/PHPMD/Rule/AbstractLocalVariable.php
@@ -288,12 +288,17 @@ protected function isPassedByReference($variable)
     {
         $parent = $this->getNode($variable->getParent());
 
-        if (!($parent && $parent instanceof ASTArguments)) {
+        if (!($parent instanceof ASTArguments)) {
             return false;
         }
 
         $argumentPosition = array_search($this->getNode($variable), $parent->getChildren());
-        $function = $this->getNode($parent->getParent());
+        $parentParent = $parent->getParent();
+        if ($parentParent === null) {
+            return false;
+        }
+        $function = $this->getNode($parentParent);
+
         $functionParent = $this->getNode($function->getParent());
         $functionName = $function->getImage();