Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candles doesn't fill canvas in some datasets #17

Closed
MakeSomeGood opened this issue Apr 22, 2019 · 6 comments
Closed

Candles doesn't fill canvas in some datasets #17

MakeSomeGood opened this issue Apr 22, 2019 · 6 comments
Labels
improvement Something might work better

Comments

@MakeSomeGood
Copy link
Contributor

Thanks for the great project. Really has a lot of promise compared to the other charting libs out there.

The issue I found is that when loading certain datasets, the candles doesn't fill the entire canvas and cuts off at that point even when scrolling. I found the issue using AAPL's daily candles since 2000.

Here's a short video of the issue and the data set I used:
Video of issue
AAPL Dataset
@C451 C451 added the bug Something isn't right label Apr 23, 2019
@C451
Copy link
Collaborator

C451 commented Apr 23, 2019 •
edited

Thanks!
Definitely a bug, I'll investigate.

@C451
Copy link
Collaborator

C451 commented Apr 23, 2019 •
edited

This seems to be one of the IMPORTANT problems caused by data time gaps.

@C451 C451 mentioned this issue Apr 26, 2019
Closed
@C451
Copy link
Collaborator

C451 commented Apr 26, 2019 •
edited

Partially fixed by f482119

Need to fix dates and hide weekend gaps.

@C451 C451 added improvement Something might work better and removed bug Something isn't right labels May 6, 2019
@C451 C451 mentioned this issue Jul 16, 2019
Closed
@msincenselee
Copy link

this is an IMPORTANT issue.

@C451
Copy link
Collaborator

C451 commented Oct 7, 2019

this is an IMPORTANT issue.

Important indeed! Do you have a solution? Detailed description: #59 (comment)

@C451
Copy link
Collaborator

C451 commented Aug 23, 2020

At this point it's fair to say: this bad mf is solved

@C451 C451 closed this as completed Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Something might work better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msincenselee @C451 @MakeSomeGood