feat (Typescript): Add typescript support , work done by @Metavirulen with PR fixes. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2018 13:34
|
Hey @jafin, is there any work being done on this PR? |
|
Is there anything else for this PR to be added? It would be great to have typings. |
|
@huyvohcmc and @TienNguyenEH and @tvkhoa (adding you all as you have recently approved a PR) Can we merge this? We presently have to pin to @jafin 's branch to have TS support |
|
Are there any plans to merge this? Would be great... 🙏 |
moshfeu
reviewed
Aug 11, 2019
package.json
Outdated
|
Tested. It works. Thank you @jafin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #24 redone with PR comments.