Only track video streams #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake where the test data for two tests were flipped in a way that resulted in data being accessed that wasn't really there. The test still passed because it was comparing the unknown value with itself.
The AbstractVideoIngestionAppliance keeps track of the position associated with the stream; however, in MPEG-TS there is more than one stream (e.g. audio and video) which means there is actually more than one stream position. This was causing issues where position was jumping around back and forth because all positions were treated as being from a single stream. We now only care about the video stream. It may be that an MPEG-TS stream can contain multiple video streams, which will break this code; that said, TV Kitchen is fairly built around an assumption that a given video stream has a single video in it. In the long run we may want to also track audio stream position, but honestly at that stage we would probably want the ingestor to output multiple demuxed and remuxed streams instead of simply forwarding the stream. Issue #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where both video and audio stream positions were tracked, resulting in false rollovers.
Related Issues
Resolves #132