Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log levels #84

Open
slifty opened this issue Aug 30, 2020 · 2 comments
Open

Log levels #84

slifty opened this issue Aug 30, 2020 · 2 comments

Comments

@slifty
Copy link
Member

slifty commented Aug 30, 2020

Task

Description

Two things I'd like to revisit around our log levels.

  1. Do we want FATAL. Every other log level is supported by node's console except FATAL. Maybe we should remove it? Would make default loggers potentially simpler.

  2. Should our constants be UPPERCASE -- we have them as lowercase because... winston? But I'm not sure that is an appropriate reason to have those constants be different from all of our other constants (and frankly, constants as UPPERCASE feels like it is kind of a standard signal).

Relevant Resources / Research

None

Related Issues

None.
@chriszs
Copy link
Contributor

chriszs commented Aug 30, 2020 •
edited

The distinction between a fatal error and an error doesn't seem particularly useful in a logger. One way to signal fatality is throw an exception.

@slifty slifty mentioned this issue Aug 30, 2020
Merged
5 tasks
@slifty slifty mentioned this issue Sep 7, 2020
Open
@slifty
Copy link
Member Author

slifty commented Sep 9, 2020

We should probably have a NOTHING level as well (since these levels are used to specify the level of logging, not just used to define log methods)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slifty @chriszs