fix unicode #117
Closed
fix unicode #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only do the various transformations when dtk-handle unicode is set * dtk-handle-unicode can be set by the user but in the next commit the various engines will set it automatically that need this.
engines mac, espeak, and most other modern ttses can handle unicode in some way, these are the only ones that really need help.
|
PR looks good, but please update it after pulling from Master since other files in the repo have changed, and I dont want to accidentally merge unrelated files. |
Hopefully this won't cause even more git breakage.
|
I've just pulled in all the newest changes. The two commits I made only I'll post a git patch on the mailing list incase this doesn't work either. |
|
Merged; thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new variable,
dtk-handle-unicode, and the variouscharacter translation functions like dtk-unicode-replace-chars only get
triggered if it's set to t. Only a minority of synthesizers today need
this functionality so the variable defaults to nil.