Remove capitalization controls from espeak server #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge in #59 in the next few mins and do a push, thanks for all the
good work, and look forward for more!
…--
Thanks,
--Raman(I Search, I Find, I Misplace, I Research)
♈ Id: kg:/m/0285kf1 🦮
I have now applied #59 but you now need to update #60 to reflect that.
I have done so many tweaks now that I am reluctant to do this by hand
against master.
Thanks for your staying the course on thisApplied to
master. Incidentally your PR 60 lost the final malloc/strncpy fix --
I restored it by hand TAL at what is on master now, I think we're
finally done with this for now.
|
krzysz00
changed the title
krzysz00
force-pushed
the
remove-espeak-capital-announcements
branch
from
2f305eb
to
aef6ee5
Compare
|
I've rebased this change on top of master and so hitting merge on this PR should work fine now. (and I also switched "driver" to "server" in the commit message) |
Announcing capitals is now solely controlled by emacspeak and the espeak synthesizer's insertion of the string "Capitalize" (or a beep or pitch change, though there is no longer a user interface for enabling this) caused redundant announcements with `dtk-split-caps`.
krzysz00
force-pushed
the
remove-espeak-capital-announcements
branch
from
aef6ee5
to
af6010e
Compare
|
Closing as merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcing capitals is now solely controlled by emacspeak and the
espeak synthesizer's insertion of the string "Capitalize" (or a beep
or pitch change, though there is no longer a user interface for
enabling this) caused redundant announcements with
dtk-split-caps.(Note that since this is branched off of
masterand not #59 , the warnings mentioned in #59 are still present here, though if ;#59 lands first I can merge it in to get rid of them)