docs: added "Thinking in Groups" section to grouping docs #69
Conversation
|
@sastan - I am unable to add a reviewer to this PR and also not sure how to get it to pass the Github Action. If you approve of the updates to the docs, please just let me know if there is anything else that I need to do to get this properly merged. Thanks. |
|
I have seen this and i'm quite whoooa... Thank you this is really helpful. The github action fails because of the format. Could you try to run yarn format. I should add a pre-commit hook do this... As i am short in time could you move this section to be one of the first or maybe the first as it is a great introduction why grouping is a powerful feature. |
docs/grouping.md
Outdated
|
|
||
| Before: `bg-purple-800 hover:bg-purple-700 focus:bg-purple-700` | ||
|
|
||
| After: `bg(purple(800 700(hover:& focus:&)))` |
There was a problem hiding this comment.
I think bg-purple(800 700(hover:& focus:&)) is a little bit more readable.
There was a problem hiding this comment.
I agree and it saves a character. Every bit counts!
docs/grouping.md
Outdated
|
|
||
| Before: `focus-visible:ring-4 ring-purple-400` | ||
|
|
||
| After: `ring(purple-400 focus-visible:(4))` |
There was a problem hiding this comment.
Do the additional braces help here: focus-visible:(4)?
Maybe change to ring(purple-400 focus-visible:4)
There was a problem hiding this comment.
Fully agree. No need for the parens.
|
I've made the requested changes and glad to hear that this is helpful! I moved the "Thinking in Groups" section to the top because it didn't make sense to me to nest it between the sections describing grouping methods. The GitHub action is still failing even with pre-commit formatting. This appears to be the culprit:
Also, I should have branched this off. I'll do that moving forward. If you'd like to see any other changes, just let me know! |
|
Thank you. Looks good. Going to merge later. The build error has something to do with the publishing of the preview package. I'll look into that. |
This PR includes a "Thinking in Groups" section of the grouping documentation, which uses a button example to demonstrate different approaches to grouping. It also includes verbiage to address the concern mentioned in #59.