-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tw.apply for component like styles #83
Conversation
Pull Request Test Coverage Report for Build 491375292
💛 - Coveralls |
size-limit report 📦
|
Try the Preview Package
This PR has been published to npm.pkg.github.com as Install/Update Configure your NPM client (click to expand)Adjust you
Using the command line: npm config set @tw-in-js:registry https://npm.pkg.github.com --global # For npm
npm install --force twind@npm:@tw-in-js/twind@pr83
# For yarn - upgrade implies install
yarn upgrade twind@npm:@tw-in-js/twind@pr83 |
Docs will follow. The api is as discussed in the issue. |
c462263
to
5915d0b
Compare
d3d2fb6
to
a63ed92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is there any concern with apply
overwriting the existing Function.prototype.apply
in JS? I suppose call
is an alternative, so perhaps not
docs/components.md
Outdated
|
||
<details><summary>Using within <code>css</code> – pending</summary> | ||
|
||
`tw.apply` can be used with `css` ( (_pending variable arguments, array support_): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still pending? Just to make sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jep. Working on a initial draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this is super nit-picky documentation grammar/capitalization changes. I'll try to run through the other docs at some point too to ensure consistency.
The recurring two are "tailwind" -> "Tailwind" and "css" -> "CSS". Tailwind refers to itself as "Tailwind" and CSS is an acronym, so it should be capitalized.
That is definitely the case. It may look odd for some developers. What use case would there be to use I'm happy to use a different name but i thought we agreed on |
That would be great. English is not my native language.
Jep. |
From a quick scan I do believe most of the other docs already style these two like this. This page is just the odd one out. |
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
@rschristian Thanks for all the suggestion. You made it really easy for me. I just needed to confirm these 🚀 |
NP, glad it could be of use. I do think there's a handful more, probably hidden behind a "Load more..." box. |
I agree, and I still think |
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
See this #83 (comment) to try it out.
Resolve #73