add clamav Windows Support #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hi @kieranjol - thanks for the contribution! It looks like there's a missing closing |
tw4l
approved these changes
Dec 4, 2021
|
Apologies, great catch! I must not have tested with the large files
scenario. Also thanks for merging, we are using Brunnhilde quite a lot now
in the National Library of Ireland!
…On Sat 4 Dec 2021 at 19:53, Tessa Walsh ***@***.***> wrote:
Merged #55 <#55> into develop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAITFPXUTWRPDMC2SJSL6ZLUPJWT3ANCNFSM5HXZ6SWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Eek, I also realise that I selected the develop branch, rather than main! Should that be merged into main? |
|
No that's okay! I switched it to develop :) I like to merge the whole branch into main at release time. Thank you!!
…On Mon, Dec 6, 2021, at 10:25 AM, kieranjol wrote:
Eek, I also realise that I selected the develop branch, rather than main! Should that be merged into main?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTSDFA543YU273QT6QP5FDUPTIVXANCNFSM5HXZ6SWQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Ah perfect, I just thought I'd made another mistake. Thank you Tessa! |
tw4l
pushed a commit
that referenced
this pull request
Jan 14, 2022
- Add clamav Windows Support - Add missing single quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tessa,
So I finally got around to testing this on both Windows and MacOS - it seems to work just fine. on MacOS, the report is also printed to the terminal and to the logfile. Let me know what you think and if I need to do or test anything else.
K