Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update name of app validation #617

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

liudonghua123
Copy link
Contributor

PR for #614, tested ok locally.

image

@tw93
Copy link
Owner

tw93 commented Dec 8, 2023

Thanks for submitting this pr, I usually use mac more, seldom see we-read this kind of naming, not particularly clear windows under the case of this application naming style?

Is there any example of this application naming style under windows? I'm usually more used to using capitalization humps, such as WeRead

@Tlntin
Copy link
Collaborator

Tlntin commented Dec 8, 2023

Thanks for submitting this pr, I usually use mac more, seldom see we-read this kind of naming, not particularly clear windows under the case of this application naming style?

Is there any example of this application naming style under windows? I'm usually more used to using capitalization humps, such as WeRead

Linux often do like this.

@liudonghua123
Copy link
Contributor Author

I think the style of naming choices should leave to the users. The app or tool only need to guarantee the name is valid. Some best practice hints could show to the users as warnings if the name is not recommend but valid.

@Tlntin Tlntin merged commit f2f0742 into tw93:master Dec 11, 2023
8 checks passed
@liudonghua123 liudonghua123 deleted the app_name_update branch December 11, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants