We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I ran into an issue when uploading my own minimesh, but it seems to be a quick fix (if the fix is correct) so I figured I would write it down here.
In the MiniTransform code:
chordatlas/src/org/twak/readTrace/MiniTransform.java
Line 120 in b77561b
Should this line actually be:
double edgeLength = Math.pow( volume / ( (double)count / targetCount ), 0.3333 );
which casts count to a double before dividing? Otherwise if count < targetCount, we are dividing by 0 and edgeLength becomes infinity.
count
double
count < targetCount
edgeLength
The text was updated successfully, but these errors were encountered:
I agree this is a bug!
This might be a bit smoother if I have your dataset? (Obviously) not many people have used this pipeline except me...
Sorry, something went wrong.
fix for #16
df16134
fixed here: df16134
No branches or pull requests
I ran into an issue when uploading my own minimesh, but it seems to be a quick fix (if the fix is correct) so I figured I would write it down here.
In the MiniTransform code:
chordatlas/src/org/twak/readTrace/MiniTransform.java
Line 120 in b77561b
Should this line actually be:
double edgeLength = Math.pow( volume / ( (double)count / targetCount ), 0.3333 );
which casts
count
to adouble
before dividing? Otherwise ifcount < targetCount
, we are dividing by 0 andedgeLength
becomes infinity.The text was updated successfully, but these errors were encountered: