Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniTransform Bug? #16

Closed
leekkww opened this issue Apr 10, 2019 · 2 comments
Closed

MiniTransform Bug? #16

leekkww opened this issue Apr 10, 2019 · 2 comments

Comments

@leekkww
Copy link
Contributor

leekkww commented Apr 10, 2019

I ran into an issue when uploading my own minimesh, but it seems to be a quick fix (if the fix is correct) so I figured I would write it down here.

In the MiniTransform code:

double edgeLength = Math.pow( volume / ( count / targetCount ), 0.3333 );

Should this line actually be:

double edgeLength = Math.pow( volume / ( (double)count / targetCount ), 0.3333 );

which casts count to a double before dividing? Otherwise if count < targetCount, we are dividing by 0 and edgeLength becomes infinity.

@twak
Copy link
Owner

twak commented Apr 11, 2019

I agree this is a bug!

This might be a bit smoother if I have your dataset? (Obviously) not many people have used this pipeline except me...

twak added a commit that referenced this issue Apr 11, 2019
@twak
Copy link
Owner

twak commented Apr 12, 2019

fixed here: df16134

@twak twak closed this as completed Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants