Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events leak #4

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Fix events leak #4

merged 2 commits into from
Jan 9, 2019

Conversation

dex4er
Copy link
Collaborator

@dex4er dex4er commented Jan 8, 2019

Without this patch I see a message like this:

(node:46858) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added. Use emitter.setMaxListeners() to increase limit

The library should clean up its listeners on close.

@dex4er
Copy link
Collaborator Author

dex4er commented Jan 8, 2019

I think you forgot to push 3.14.0 to github

@dex4er dex4er merged commit dde3555 into twawszczak:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dex4er