New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign to match docs site #115
Conversation
Some thoughts:
|
@mdo totally forgot about this, please ping us when it's ready for review. |
555b3a2
to
7efe312
Compare
Alright, I pushed some patches. My main issue is with the page renames. We can't redirect them easily, so we should rename list to archive here. Similarly for any other page renames; if it's one page we can redirect it client-side, but if the pages are a lot, I'm not sure it's worth it. EDIT: NVM, it is one page so I redirected it. EDIT 2: navbar-nav-scroll needs a little padding/margin so that there's more space on mobile. /CC @MartijnCuppens |
Also, I don't think the footer license text is right. The blog code is not using the mentioned license AFAICT. |
This is good to go I think. Original comment has been updated on list of todos that I'm punting on. @XhmikosR let me know if there are any showstoppers here. |
It's not consistent, but it doesn't require many changes this way. Also, reuse the `site.main` variable.
@mdo I rebased this, cleaned up the patches a bit and updated to v4.4.1. Let me know if everything LGTY. One thing I was thinking is if we should use |
Thanks! For now, I think we should explicitly upgrade to avoid any unforeseen issues. |
Feel free to merge without squashing :) |
Move to source Bootstrap instead of CDN distSticking with CDN v4.4.0 linkAutomate the site build after merge with Actions?