Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign to match docs site #115

Merged
merged 12 commits into from Dec 3, 2019
Merged

Redesign to match docs site #115

merged 12 commits into from Dec 3, 2019

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 31, 2019

  • Revamp other pages
  • Fix links in subnav
  • Update to latest version of Bootstrap
  • Move to source Bootstrap instead of CDN dist Sticking with CDN v4.4.0 link
  • Fix URLs, trailing slashes etc
  • Adapt paginate style
  • Automate the site build after merge with Actions?
  • Remove commented out code
  • Update CSS syntax to Sass syntax

@XhmikosR
Copy link
Member

XhmikosR commented Aug 1, 2019

Some thoughts:

  1. we can't have autoprefixer on GH pages and we definitely need it
  2. I fixed some URL issues, I need to check if there are more

_sass/_theme.scss Outdated Show resolved Hide resolved
_sass/_theme.scss Outdated Show resolved Hide resolved
_sass/_theme.scss Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member

@mdo totally forgot about this, please ping us when it's ready for review.

_config.yml Outdated Show resolved Hide resolved
_config.yml Show resolved Hide resolved
_includes/subnav.html Outdated Show resolved Hide resolved
@XhmikosR XhmikosR force-pushed the redesign branch 3 times, most recently from 555b3a2 to 7efe312 Compare November 8, 2019 14:59
@XhmikosR
Copy link
Member

XhmikosR commented Nov 8, 2019

Alright, I pushed some patches.

My main issue is with the page renames. We can't redirect them easily, so we should rename list to archive here. Similarly for any other page renames; if it's one page we can redirect it client-side, but if the pages are a lot, I'm not sure it's worth it.

EDIT: NVM, it is one page so I redirected it.

EDIT 2: navbar-nav-scroll needs a little padding/margin so that there's more space on mobile. /CC @MartijnCuppens

@XhmikosR
Copy link
Member

XhmikosR commented Nov 8, 2019

Also, I don't think the footer license text is right. The blog code is not using the mentioned license AFAICT.

@mdo mdo marked this pull request as ready for review November 26, 2019 23:12
@mdo
Copy link
Member Author

mdo commented Nov 27, 2019

This is good to go I think. Original comment has been updated on list of todos that I'm punting on. @XhmikosR let me know if there are any showstoppers here.

@XhmikosR
Copy link
Member

@mdo I rebased this, cleaned up the patches a bit and updated to v4.4.1.

Let me know if everything LGTY.

One thing I was thinking is if we should use current_version in the CDN link. It has its pros and cons, but at least everything will be controlled from the config file.

@mdo
Copy link
Member Author

mdo commented Nov 30, 2019

Thanks! For now, I think we should explicitly upgrade to avoid any unforeseen issues.

@XhmikosR
Copy link
Member

Feel free to merge without squashing :)

@mdo mdo merged commit 0fccf84 into gh-pages Dec 3, 2019
@mdo mdo deleted the redesign branch December 3, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants