Update posts to move author to metadata #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Jan 11, 2021
| @@ -0,0 +1,4 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="{{ include.width }}" height="{{ include.height }}" class="{{ include.class }}" viewBox="0 0 16 16" role="img" fill="currentColor"> | |||
There was a problem hiding this comment.
If we are not using different width/height, I'd say we better hardcode this. And also do this for the other icons assuming we don't pass any different values.
|
I'll check it out later to make sure the SEO tags are fine too. |
XhmikosR
reviewed
Jan 11, 2021
XhmikosR
reviewed
Jan 11, 2021
XhmikosR
force-pushed
the
updated-post-meta
branch
from
07190c7
to
ca9e47e
Compare
|
I pushed a few more patches. Not sure I love jekyll-avatar because of its lack of customization (even its lazy option doesn't work with our JS library nor can we pass And I'll try lazyloading the avatars later. |
XhmikosR
force-pushed
the
updated-post-meta
branch
from
ca9e47e
to
0f38d81
Compare
|
I reverted the jekyll-avatar addition and just moved common code to an include. Should be good to go. Looking good as a start! |
XhmikosR
approved these changes
Jan 13, 2021
XhmikosR
force-pushed
the
updated-post-meta
branch
from
0f38d81
to
0d57778
Compare
Similarly to what we do with the videos.
We can expand this later to use `time`
XhmikosR
force-pushed
the
updated-post-meta
branch
2 times, most recently
from
27d8417
to
4a878c4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More traditional layout on index and individual posts by having author avatar and name at the top. Also adds an icon from Bootstrap Icons for the date, with a new date format that looks more complete.
Moves all post authors to single authors, to be in the front matter, and removes the
<3, ...sign-off from all posts.