This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Node.js version: implement reporting of locations of problematic elements #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+:100: |
|
The |
…ents Fixes #29 (or rather, finishes fixing it) <3 to https://github.com/cheeriojs/cheerio & @fb55 !
|
Yup, have fixed that as part of getting Travis green. |
| @@ -753,14 +755,29 @@ var semver = require('semver'); | |||
| } | |||
| }); | |||
|
|
|||
| exports._lint = function ($, reporter, disabledIdList) { | |||
| exports._lint = function ($, reporter, disabledIdList, html) { | |||
| var locationIndex = IN_NODE_JS ? new LocationIndex(html) : null; | |||
There was a problem hiding this comment.
Am I missing where IN_NODE_JS is defined?
There was a problem hiding this comment.
Ah, I see. It doesn't work for me in the CLI and I thought it was this. Never mind, it works great. I just need to properly wake up.
|
Works great |
|
Seems to work fine, great job! |
cvrebert
added a commit
that referenced
this pull request
Nov 7, 2014
Node.js version: implement reporting of locations of problematic elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29. (or rather, finishes fixing it)
CC: @hnrch02 @XhmikosR @zacechola for review and/or testing