This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Update cheerio to v1.0.0-rc.3. #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas @Johann-S? https://github.com/twbs/grunt-bootlint/tree/xmr-cheerio-test see how tests fail there |
|
Not sure but in |
|
@Johann-S I think this is the cause cheeriojs/cheerio@0.22.0...v1.0.0#diff-e1bbd4f15e3b63427b4261e05b948ea8R24 It just that happens to be triggered on grunt-bootlint, but we need to think how to proceed here. |
XhmikosR
force-pushed
the
xmr-cheerio
branch
from
4251810
to
154308a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I can't figure out. While tests here pass fine, they break on grunt-bootlint
https://github.com/twbs/grunt-bootlint/commits/xmr-cheerio-test
If anyone has any ideas please let me know.