Bootstrap 2.1.0 released!

[nickelser]

I know you are probably hard at work converting the latest version (or someone is ;-), but just wanted to give a heads up (and an issue to slam shut when finished).

tom edit: Can I ask that you stop +1ing this issue thread now, it's not going to get it released any quicker. I have a few hours tonight to look at it, and I will release 2.0.4.1 before with the fixes currently inbranch for those not looking to upgrade. If you want an email notification on release you can subscribe to the issues thread at the bottom of the page. Cheers!

[caiotarifa]

+1

The new version is fantastic!
I'll try to help as possible!

[McPants]

Can't wait!

[thomas-mcdonald]

Yeah, I'll take a look at it later.

[asnoba]

+1

[atipugin]

+1

[pex]

+1

[kaluznyo]

+1

[kuhsaft]

+1

[camoedo]

+1

[Tolchi]

+1

[bigjason]

👍

[swobspace]

+1

[potatosalad]

+1

[elitheeli]

+2

[Jachobsen]

+1

[discoliam]

+1

[superchink]

@thomas-mcdonald is there any documentation of the process you've been following to convert to sass? It might help get some assistance in maintaining and working through updating when official releases are announced.

[jonchay]

+1

[alexandrecolas]

+1

[gtd]

Guys, did you not see Tom's edit on the original issue? Please stop spamming him with +s, he's on it.

[badp]

-17

^{there I fixed it}

[pixelsonly]

@superchink I was thinking the same thing. I've worked through a few areas myself but mixins in particular can get a bit tricky.

[aaronbrethorst]

I won't +1 this, but I'd love it if you could put a GitTip (or whatever) on this project so I can pay you. You've saved me a ridiculous amount of time over the past few months with your hard work. The least I can do is (virtually) buy you a beer or six.

thx,
aaron

(edit: apparently gittip doesn't allow me to give you a one-off donation, which I think is dumb.)

[sixty4bit]

I second @aaronbrethorst request. I would like to make a donation as well. Thanks for the excellent work.

[bramswenson]

I third @aaronbrethorst bootstrap-sass is a great time saver!

[zegal74]

+1

[dszczyt]

I hav started the work on https://github.com/dszczyt/bootstrap-sass . Still doesn't work, I'm trying to solve the issues...

EDIT : work done, sass compiles, tests pass, waiting for seeing it in action...

[ghost]

@dszczyt how can i use your fork in my current project? I alraedy have bootstrap-sass gem installed, i attempted to modify my gemfile

gem "bootstrap-sass", :git => 'git://github.com/dszczyt/bootstrap-sass.git'

and then run

~> gem uninstall bootstrap-sass && bundle install

but its still referencing 2.0.4.0

[dszczyt]

I didn't change the version number in the gemspec file. Fixed.
I ran the command :

find ~/.rvm -iname bootstrap-sass-2.0\* -exec r m -r {} \; 

(be careful before running this command, remove the space between the r and the m after checking !)
Ran bundle update again...
And.... surprise ! it works !!!

[rykov]

If you're not seeing changes, touch the files that have @include 'bootstrap' to flush the caches

Also, $gridColumnWidth and $gridGutterWidth don't seem to be working in @dszczyt's branch

[dszczyt]

should work with my last update

[corny]

SASS 3.2 has been released as well. It would like to see bootstrap-sass depending on SASS 3.2 to support variables in Media Queries (see #107)

[rvrm]

@dszczyt: I'm getting Mixin gridInput is missing argument $gutterWidth

[javiercr]

I've switched to @dszczyt's fork but is still serving the old Bootstrap. I've tried to touch the files with the include but the same result. Any tip?

[javiercr]

OK, answering myself:

gem uninstall bootstrap-sass
bundle update bootstrap-sass

Now it works.

[pdf]

@corny depending on sass 3.2 should not happen at this time, in this gem. First, sass-rails is still at 3.1, so if you want newer sass, go file an issue against that gem. Also, this gem is already ~> 3.1, so if you explicitly ask for sass-rails 3.2 (assuming it's released at some stage), you won't get a conflict. Finally, your request is completely off-topic to this issue and has no place here.

[corny]

@pdf ok, I agree with you.

[dszczyt]

@rvrm do you have the issue again ?

[sclara]

@dszczyt I have the same issue. Mixin gridInput is missing argument $gutterWidth.

[dszczyt]

Are you using the responsive version ? There were mistakes in it. It should work now.

[m47730]

Guys, i think is a bit unpleasant talking about dszczyt fork here.
If you want support for his version (that i'm going to use, and i thanks him for his work) i think is more appropriate to go to his github fork page.

[dszczyt]

And if @thomas-mcdonald wants to merge my branch, I'm ok with that :) I just reused most of his work...
And thanks to @keysen who helped me to do it faster.

[hadees]

@dszczyt why not issue a pull request then? I doubt he is reading this comment thread. Otherwise if you end up keeping up with the fork I'd suggest renaming the gem. However I wouldn't see why @thomas-mcdonald wouldn't be willing to merge in your changes.

[sgrif]

Can we get an update on where this is at?

[designium]

+1

[thomas-mcdonald]

I've been at Leeds Festival this weekend, and something came up the other night which meant I couldn't get the time to work on an update.

I see there has been a pull request with the update but it breaks with Sass 3.1. I'm going to go through it now, fix it & push it onto a branch for testing.

[ghost]

+1 @thomas-mcdonald you rock.

[neersighted]

👍 Amazing work! I'm using anjlab/bootstrap-rails right now, but plan to switch back as soon as this is finished!

[Linuus]

I really look forward to the new 2.1 stuff :) Can't wait! Please let us know if there is anything we can help you with @thomas-mcdonald

[thomas-mcdonald]

gem 'bootstrap-sass', git: 'git://github.com/thomas-mcdonald/bootstrap-sass', branch: '2.1-wip'

A combination of the changes in #185 and some bits redone (grid generation), as well as (what should be, travis is down) fixes for Sass 3.1.

Give it a whirl and create a new issue if you find problems, although I've replaced the compiled output with the documentation CSS and everything looked fine, so there hopefully shouldn't be too many. I'll push a gem release in a couple of days if there's no more issues to report.

[neersighted]

@thomas-mcdonald YOU ARE MY HERO! Thank you!

[cice]

awesome.

[ffloyd]

@thomas-mcdonald thanks! You made my day!

[hamo]

@thomas-mcdonald THANK YOU VERY MUCH! You do a GREAT job my hero!

[wikiziner]

+1 ,,, Thank You @thomas-mcdonald

[neersighted]

👍

[thomas-mcdonald]

Pushed the gem yo.

[john]

Thank you!

[aaronbrethorst]

Woohoo! Thanks!

On Sep 6, 2012, at 8:36 AM, Thomas McDonald notifications@github.com wrote:

Pushed the gem yo.

—
Reply to this email directly or view it on GitHub.

[keilmillerjr]

Thank you!

[dbrock]

Yay!! :D

Now I 1) will get to try Bootstrap 2.1.0, and 2) won't get these
notifications any more!

Thanks for the work guys.

[neersighted]

You sir, are a gentleman and a scholar.

[rooshdi]

Thank You! You are awesome!

On Sep 6, 2012 10:36 AM, "Thomas McDonald" notifications@github.com wrote:

Pushed the gem yo.

—
Reply to this email directly or view it on GitHub.

[image]

[darthdeus]

And now we just need to bump to 2.1.1 :)

[mikeg250]

Github needs a DONATE button! Thank you Thomas!