Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap-sass should be framework agnostic #26

Closed
thomas-mcdonald opened this issue Jan 17, 2012 · 15 comments
Closed

Bootstrap-sass should be framework agnostic #26

thomas-mcdonald opened this issue Jan 17, 2012 · 15 comments
Milestone

Comments

@thomas-mcdonald
Copy link
Member

because I hear that there's some people not using Rails, it would be cool if they can join in the fun.

Consider this a ticket to track progress and such.

@Pewpewarrows
Copy link

I'd love to see this as a Compass plugin that I can just pull-in to any project.

@brentkirby
Copy link

Does anyone really even use sass gems without either compass or rails? (or both) I'd imagine anyone using a sass library in a "standalone" environment is probably using compass but maybe not?

I don't see why starting out with rails and compass support (separately or together if your using both) is a problem. If Rails is loaded, load the engine. Include files etc for compass so it can function as a compass extension when working in a non-rails environment. I'd imagine the gemspec wouldn't require either of them except maybe as development dependencies (if you wanted to contribute writing helpers and such). Should probably add a test framework for development as well. I'd just use rspec unless anyone else objects to that :) Using minitest/testunit is fine too, or i guess technically we could run both.

@oskarrough
Copy link

It would be fair to make the port of Bootstrap to sass rely on Compass, seing as almost every sass user is using it.

@brentkirby, it's not a problem per se, but Bootstrap as is, is a front-end toolkit and not dependent on any other framework. Having said that, I don't even know what gemspec is. Just not sure I see why Bootstrap should be mixed with with anything else but sass.

@thomas-mcdonald
Copy link
Member Author

@brentkirby Yeah, we'll make boostrap-sass either a rails/compass library, depending on which one we can load.

I'll hold off pushing any of the Rails-specific stuff until we have conditional loading nailed down, want to make a start? I still have exams until this time next week so I can't commit to too much input this side of them.

@brentkirby
Copy link

sure. just forked it. Is everything up to date on the 2.0 branch?

@thomas-mcdonald
Copy link
Member Author

I think this is the set of changes.

@thomas-mcdonald
Copy link
Member Author

@brentkirby We have a week before Bootstrap 2.0 is released. My exams also finish tomorrow afternoon, so I've got a couple of days to hack on bootstrap-sass, but I don't want to duplicate any of your work if you have some stuff to push up and merge in. If you don't, I'll just plough on with this ticket tomorrow.

@oskarrough
Copy link

Wouldn't it make it a lot easier for us if we waited with the conversion until their testing and feedback have ended?

@nhance
Copy link

nhance commented Jan 27, 2012

Is there a branch with some work in progress on this? I'd love to finish this up so we can start using this in an internal project.

@allaire
Copy link

allaire commented Feb 1, 2012

Bootstrap 2 is coming out tonight, did you guys we'll have a working version soon of the 2.0? What did you do finally, went rails or sass only?

@sevenseacat
Copy link

A lot of sass users aren't using compass, where did that idea come from? :/ Please don't make it rely on compass!

@oskarrough
Copy link

Using Compass with Sass is a huge advantage but I'm fine keeping the port more one-to-one, converting the Less mixins Bootstrap has.

@sevenseacat
Copy link

Is a huge advantage if you like and use compass, yeah.

@thomas-mcdonald
Copy link
Member Author

The 2.0 branch now has support for either the Rails asset pipeline or Compass. I'm currently looking at what changes will be needed for an Rails application that also uses Compass, just looks like I'll need to set a couple of configuration variables.

@thomas-mcdonald
Copy link
Member Author

Consider this complete.

@twbs twbs locked and limited conversation to collaborators Feb 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants