Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from bower install example #520

Closed
wants to merge 1 commit into from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Feb 3, 2014

Fixes gh-519

@glebm
Copy link
Member

glebm commented Feb 3, 2014

Removing quotes makes your shell treat the version number as a comment

@glebm glebm closed this Feb 3, 2014
@nschonni
Copy link
Contributor Author

nschonni commented Feb 3, 2014

In a shell script maybe, not from the command line

@glebm
Copy link
Member

glebm commented Feb 3, 2014

It is in e.g. zsh by default. Currently asking about "" in the issue

@nschonni nschonni deleted the patch-1 branch February 3, 2014 20:37
@glebm
Copy link
Member

glebm commented Feb 4, 2014

Turns out the number was only necessary because Bower does not support 4-digit version tags (invalid semver). We use 3-digit tags since v3.1.0. I've updated the readme.

@nschonni
Copy link
Contributor Author

nschonni commented Feb 4, 2014

If the package gets published it can be simplified to bower install bootstrap-sass

@glebm
Copy link
Member

glebm commented Feb 4, 2014

Another package had taken the name before bootstrap-sass was made official. There is a pending renaming request in the ever-expanding Bower issue. Not sure if funny or sad.

@nschonni
Copy link
Contributor Author

nschonni commented Feb 4, 2014

I know I've run into that with another project too 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bower install of Bootstrap-Sass
2 participants