Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap.js file difference #777

Closed
mnabialek opened this Issue Nov 15, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@mnabialek
Copy link

commented Nov 15, 2014

I don't know if it's an issue but I looked at this file and compared it with original bootstrap.js file. This file is a bit different. There is no:

if (typeof jQuery === 'undefined') {
  throw new Error('Bootstrap\'s JavaScript requires jQuery')
}

+function ($) {
  var version = $.fn.jquery.split(' ')[0].split('.')
  if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1)) {
    throw new Error('Bootstrap\'s JavaScript requires jQuery version 1.9.1 or higher')
  }
}(jQuery);

part and the order of other parts is also different. If it's not a bug or issue, why this file is different than original file?

@mnabialek mnabialek changed the title bootstrap.js file diference bootstrap.js file difference Nov 15, 2014

@glebm glebm added the feature label Nov 15, 2014

@glebm

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2014

At the moment we generate the file from the individual JS files. Instead, we should copy the file from upstream dist/.

glebm added a commit that referenced this issue Nov 15, 2014

Use dist/js/bootstrap.js from upstream #777
Before we compiled bootstrap.js by concatenating individual files.
This copies the file from upstream for maximum compatibility.
@glebm

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2014

@mnabialek Thanks for brining this up. This is now fixed with the commit above.

@glebm glebm closed this Nov 15, 2014

@glebm glebm added this to the v3.3.2 milestone Nov 15, 2014

@mnabialek

This comment has been minimized.

Copy link
Author

commented Nov 15, 2014

@glebm I would then also recommend adding minified version of this file into the same folder as in original Bootstrap

glebm added a commit that referenced this issue Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.