Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar (fixed navbar) dropdown menu broken on 3.3.3, 3.3.2 #829

Closed
FranzZemen opened this issue Jan 20, 2015 · 12 comments
Closed

Navbar (fixed navbar) dropdown menu broken on 3.3.3, 3.3.2 #829

FranzZemen opened this issue Jan 20, 2015 · 12 comments

Comments

@FranzZemen
Copy link

Works on 3.3.1, not on 3.3.2 or 3.3.3.

Clicking on the drop down does nothing. Regular

  • menu items work.

  • @FranzZemen FranzZemen changed the title Navbar (fixed) dropdown menu broken on 3.3.3 Navbar (fixed navbar) dropdown menu broken on 3.3.3 Jan 21, 2015
    @FranzZemen FranzZemen changed the title Navbar (fixed navbar) dropdown menu broken on 3.3.3 Navbar (fixed navbar) dropdown menu broken on 3.3.3, 3.3.2 Jan 21, 2015
    @cvrebert
    Copy link
    Collaborator

    What OS and browser are you using?

    @FranzZemen
    Copy link
    Author

    Chrome, Windows OSX centOS
    On Jan 23, 2015 10:31 AM, "Chris Rebert" notifications@github.com wrote:

    What OS and browser are you using?


    Reply to this email directly or view it on GitHub
    #829 (comment).

    @FranzZemen
    Copy link
    Author

    In addition, here is the relevant markeup. The products menu doesn't
    expand under the said versions. All I change is the sassbootstrap version
    back to .1 and it works.

        <div class="container-fluid">
            <div class="row">
                <div class="col-lg-12">
                    <nav class="navbar navbar-default navbar-fixed-top">
                        <div class="container">
                            <div class="navbar-header">
                                <button type="button" class="navbar-toggle
    

    collapsed" data-toggle="collapse"
    data-target="#nav1">

    Toggle
    Navigation












    blah blah blah stuff goes here.

    On Sat, Jan 24, 2015 at 6:08 PM, Franz Zemen franzzemen@gmail.com wrote:

    Chrome, Windows OSX centOS
    On Jan 23, 2015 10:31 AM, "Chris Rebert" notifications@github.com wrote:

    What OS and browser are you using?


    Reply to this email directly or view it on GitHub
    #829 (comment)
    .

    @cvrebert
    Copy link
    Collaborator

    @FranzZemen Could you post an example that doesn't involve Angular?

    @shawnacscott
    Copy link
    Contributor

    Here's a reproduction case: https://gist.github.com/shawnacscott/e4b5054cf61589b14cc7

    I'm having this issue as well, though with a Rails installation. Reverting to 3.3.1 fixes the problem for me.

    OS X 10.10.1
    Firefox Developer Edition 37.0a2 (2015-02-03)

    @cvrebert
    Copy link
    Collaborator

    @shawnacscott Please confirm that you're using Autoprefixer.

    @shawnacscott
    Copy link
    Contributor

    @cvrebert I have gem 'autoprefixer-rails', '>= 5.0' in my Gemfile, and Gemfile.lock shows:

    autoprefixer-rails (5.1.1)
          execjs
          json
    

    and

    bootstrap-sass (3.3.3)
          autoprefixer-rails (>= 5.0.0.1)
          sass (>= 3.2.19)
    

    Here's a gist of my full Gemfile: https://gist.github.com/shawnacscott/08c89617d339da88ca02

    @glebm
    Copy link
    Member

    glebm commented Feb 12, 2015

    How are you including the JavaScript? It would be very easy for us to reproduce if you publish a minimal rails app with this issue.

    @FranzZemen
    Copy link
    Author

    In my case I'm using angular-fullstack, so its via bower components and
    then concatenated, minified etc. However, I have a dev build that doesn't
    concatenate or minify, just includes the bower files via script tag, same
    result.

    On Thu, Feb 12, 2015 at 4:55 PM, Gleb Mazovetskiy notifications@github.com
    wrote:

    How are you including the JavaScript?


    Reply to this email directly or view it on GitHub
    #829 (comment).

    shawnacscott added a commit to shawnacscott/dropdown-reproduction-bootstrap-sass that referenced this issue Feb 18, 2015
    @shawnacscott
    Copy link
    Contributor

    Your wish is my command, @glebm :)

    glebm added a commit to glebm/dropdown-reproduction-bootstrap-sass that referenced this issue Feb 18, 2015
    @glebm
    Copy link
    Member

    glebm commented Feb 19, 2015

    @shawnacscott In your example Bootstrap javascript is included twice: bootstrap-sprockets provides individual bootstrap JS files (alert.js, dropdown.js), while
    bootstrap provides a concatenated file with all of the bootstrap JS in it. Only one of these should be required, not both. I realize how confusing this must be given that for Sass, both bootstrap-sprockets, which provides Sprockets asset path support, and bootstrap must be imported.

    The dropdown menu works after removing one of the //= requires.

    shawnacscott added a commit to shawnacscott/bootstrap-sass that referenced this issue Feb 20, 2015
    @shawnacscott
    Copy link
    Contributor

    Thanks, that was it. I'll send a PR adding a caveat in the README.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants