Use for...of in visual tests too

twbs · Oct 5, 2021 · 598b4c5 · 598b4c5
1 parent 3afe4b8
commit 598b4c5
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 35 deletions.
diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html
@@ -220,15 +220,14 @@ <h4 class="modal-title" id="slowModalLabel">Lorem slowly</h4>
         }
       }
 
-      Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
-        .forEach(function (popover) {
-          new Popover(popover)
-        })
-
-      var tooltipList = Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
-      tooltipList.forEach(function (tooltip) {
-        new Tooltip(tooltip)
-      })
+      var popoverElements = document.querySelectorAll('[data-bs-toggle="popover"]')
+      for (const popoverEl of popoverElements) {
+        new Popover(popoverEl)
+      }
+      var tooltipElements = document.querySelectorAll('[data-bs-toggle="tooltip"]')
+      for (const tooltipEl of tooltipElements) {
+        new Tooltip(tooltipEl)
+      }
 
       var tallToggle = document.getElementById('tall-toggle')
       var tall = document.getElementById('tall')

diff --git a/js/tests/visual/popover.html b/js/tests/visual/popover.html
@@ -40,10 +40,10 @@ <h1>Popover <small>Bootstrap Visual Test</small></h1>
     <script src="../../dist/tooltip.js"></script>
     <script src="../../dist/popover.js"></script>
     <script>
-      Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="popover"]'))
-        .forEach(function (popover) {
-          new Popover(popover)
-        })
+      var popoverElements = document.querySelectorAll('[data-bs-toggle="popover"]')
+      for (const popoverEl of popoverElements) {
+        new Popover(popoverEl)
+      }
     </script>
   </body>
 </html>
diff --git a/js/tests/visual/toast.html b/js/tests/visual/toast.html
@@ -57,26 +57,26 @@ <h1>Toast <small>Bootstrap Visual Test</small></h1>
     <script src="../../dist/toast.js"></script>
     <script>
       window.addEventListener('load', function () {
-        Array.from(document.querySelectorAll('.toast'))
-          .forEach(function (toastNode) {
-            new Toast(toastNode)
-          })
+        var toastElements = document.querySelectorAll('.toast')
+        for (const toastEl of toastElements) {
+          new Toast(toastEl)
+        }
 
-          document.getElementById('btnShowToast').addEventListener('click', function () {
-            Array.from(document.querySelectorAll('.toast'))
-              .forEach(function (toastNode) {
-                var toast = Toast.getInstance(toastNode)
-                toast.show()
-              })
-          })
+        document.getElementById('btnShowToast').addEventListener('click', function () {
+          var toastElements = document.querySelectorAll('.toast')
+          for (const toastEl of toastElements) {
+            var toast = Toast.getInstance(toastEl)
+            toast.show()
+          }
+        })
 
-          document.getElementById('btnHideToast').addEventListener('click', function () {
-            Array.from(document.querySelectorAll('.toast'))
-              .forEach(function (toastNode) {
-                var toast = Toast.getInstance(toastNode)
-                toast.hide()
-              })
-          })
+        document.getElementById('btnHideToast').addEventListener('click', function () {
+          var toastElements = document.querySelectorAll('.toast')
+          for (const toastEl of toastElements) {
+            var toast = Toast.getInstance(toastEl)
+            toast.hide()
+          }
+        })
       })
     </script>
   </body>

diff --git a/js/tests/visual/tooltip.html b/js/tests/visual/tooltip.html
@@ -92,10 +92,10 @@ <h1>Tooltip <small>Bootstrap Visual Test</small></h1>
         })
       }
 
-      Array.prototype.slice.call(document.querySelectorAll('[data-bs-toggle="tooltip"]'))
-        .forEach(function (tooltip) {
-          new Tooltip(tooltip)
-        })
+      var tooltipElements = document.querySelectorAll('[data-bs-toggle="tooltip"]')
+      for (const tooltipEl of tooltipElements) {
+        new Tooltip(tooltipEl)
+      }
 
       var tooltipElement = document.getElementById('tooltipElement')
       var tooltipElementInstance = new Tooltip(tooltipElement, {