Skip to content

Commit

Permalink
Remove now unnecessary -ms-viewport and -ms-overflow-style directives
Browse files Browse the repository at this point in the history
Edge/Mobile appears to have moved support for `-ms-viewport` behind a flag at some point, instead supporting meta viewport directives.
Removing this altogether also fixes issues in IE11 on high-dpi displays - see #21780
  • Loading branch information
patrickhlauke committed Dec 6, 2018
1 parent 6c00dd0 commit 5cd472f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 29 deletions.
17 changes: 2 additions & 15 deletions scss/_reboot.scss
Expand Up @@ -14,9 +14,7 @@
// 2. Change the default font family in all browsers.
// 3. Correct the line height in all browsers.
// 4. Prevent adjustments of font size after orientation changes in IE on Windows Phone and in iOS.
// 5. Setting @viewport causes scrollbars to overlap content in IE11 and Edge, so
// we force a non-overlapping, non-auto-hiding scrollbar to counteract.
// 6. Change the default tap highlight to be completely transparent in iOS.
// 5. Change the default tap highlight to be completely transparent in iOS.

*,
*::before,
Expand All @@ -28,15 +26,7 @@ html {
font-family: sans-serif; // 2
line-height: 1.15; // 3
-webkit-text-size-adjust: 100%; // 4
-ms-overflow-style: scrollbar; // 5
-webkit-tap-highlight-color: rgba($black, 0); // 6
}

// IE10+ doesn't honor `<meta name="viewport">` in some cases.
@at-root {
@-ms-viewport {
width: device-width;
}
-webkit-tap-highlight-color: rgba($black, 0); // 5
}

// Shim for "new" HTML5 structural elements to display correctly (IE10, older browsers)
Expand Down Expand Up @@ -240,9 +230,6 @@ pre {
margin-bottom: 1rem;
// Don't allow content to break outside
overflow: auto;
// We have @viewport set which causes scrollbars to overlap content in IE11 and Edge, so
// we force a non-overlapping, non-auto-hiding scrollbar to counteract.
-ms-overflow-style: scrollbar;
}


Expand Down
4 changes: 0 additions & 4 deletions scss/bootstrap-grid.scss
Expand Up @@ -5,10 +5,6 @@
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
*/

@at-root {
@-ms-viewport { width: device-width; } // stylelint-disable-line at-rule-no-vendor-prefix
}

html {
box-sizing: border-box;
-ms-overflow-style: scrollbar;
Expand Down
10 changes: 0 additions & 10 deletions site/_data/browser-bugs.yml
Expand Up @@ -48,16 +48,6 @@
origin: >
Bootstrap#18504
-
browser: >
Edge
summary: >
`@-ms-viewport{width: device-width;}` has side-effect of making scrollbars auto-hide
upstream_bug: >
Edge#7165383
origin: >
Bootstrap#18543
-
browser: >
Edge
Expand Down

0 comments on commit 5cd472f

Please sign in to comment.