change adjustDialog if conditions to help readability

twbs · Oct 8, 2021 · 86b9f9c · 86b9f9c
1 parent 6c54c1b
commit 86b9f9c
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/js/src/modal.js b/js/src/modal.js
@@ -326,12 +326,16 @@ class Modal extends BaseComponent {
     const scrollbarWidth = this._scrollBar.getWidth()
     const isBodyOverflowing = scrollbarWidth > 0
 
-    if ((!isBodyOverflowing && isModalOverflowing && !isRTL()) || (isBodyOverflowing && !isModalOverflowing && isRTL())) {
-      this._element.style.paddingLeft = `${scrollbarWidth}px`
+    const adjustPadding = property => {
+      this._element.style[property] = `${scrollbarWidth}px`
     }
 
-    if ((isBodyOverflowing && !isModalOverflowing && !isRTL()) || (!isBodyOverflowing && isModalOverflowing && isRTL())) {
-      this._element.style.paddingRight = `${scrollbarWidth}px`
+    if (isBodyOverflowing && !isModalOverflowing) {
+      adjustPadding(isRTL() ? 'paddingLeft' : 'paddingRight')
+    }
+
+    if (!isBodyOverflowing && isModalOverflowing) {
+      adjustPadding(isRTL() ? 'paddingRight' : 'paddingLeft')
     }
   }